Pin UsEquityStrategies to 4e638c5#116
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c7ebae7ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "firstrade==0.0.39", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@46ca4ea3de8f98a58e2dd86158e7f2070d085cd1", | ||
| "us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@31406abfb15507270992e62ead8d1068c03328d0", | ||
| "us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@4e638c5fc880253bf22e2e056630fbce6588256a", |
There was a problem hiding this comment.
With this pin, UsEquityStrategies adds unified derived-indicator consumption for nasdaq_sp500_smart_dca, but the platform resolver still returns {} for every profile except ibit_smart_dca (market_signal_runtime.py:29-31). In a Nasdaq Smart DCA deployment configured with FIRSTRADE_MARKET_SIGNAL_*/MARKET_SIGNAL_REQUIRED, the handoff artifacts are silently skipped and required signals are not enforced, so the strategy falls back to broker history instead of the unified technical signal bundle this version is meant to consume; add the Nasdaq consumer mapping before advancing the dependency.
Useful? React with 👍 / 👎.
1 participant
Summary
4e638c5fc880253bf22e2e056630fbce6588256aTesting
git diff --check